rajarshisarkar commented on code in PR #4500:
URL: https://github.com/apache/iceberg/pull/4500#discussion_r843687986
##########
aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSFileIO.java:
##########
@@ -111,7 +111,8 @@ public void initialize(Map<String, String> properties) {
this.metrics = ctor.newInstance("oss");
metrics.initialize(properties);
- } catch (NoSuchMethodException | ClassCastException e) {
+ } catch (NoClassDefFoundError | NoSuchMethodException | ClassCastException
e) {
+ this.metrics = MetricsContext.nullMetrics();
Review Comment:
Do suggest if there is some better way to handle the fallback. I can
implement the same for all the FileIO's in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
