kbendick commented on code in PR #4507:
URL: https://github.com/apache/iceberg/pull/4507#discussion_r844131066
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -343,8 +343,8 @@ public void commit() {
LOG.warn("Failed to load committed snapshot, skipping manifest
clean-up");
}
- } catch (RuntimeException e) {
- LOG.warn("Failed to load committed table metadata, skipping manifest
clean-up", e);
+ } catch (Throwable t) {
Review Comment:
My understanding has always been that we should only catch non-fatal
exceptions.
Is there anyway we can slim down the scope / amount of code that this larger
`try-catch` block covers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
