ajantha-bhat commented on code in PR #4464:
URL: https://github.com/apache/iceberg/pull/4464#discussion_r845383759
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -728,4 +744,20 @@ TableOperations ops() {
Set<String> deletedFiles() {
return deletedFiles;
}
+
+ /**
+ * Exception used to avoid retrying {@link PendingUpdate} when it is failed
with {@link CommitFailedException}.
+ */
+ private static class ValidationFailureException extends RuntimeException {
Review Comment:
`ValidationFailureException` in `CatalogHandlers` is more about Illegal
arguments. So, it is validation failure exception.
Here it is more of failed to apply pending update. Even though the purpose
is to abort, they can have different explanations based on the context.
Hence renamed `ValidationFailureException` to `PendingUpdateFailedException`
in BaseTransaction instead of making common code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
