kbendick commented on code in PR #4532:
URL: https://github.com/apache/iceberg/pull/4532#discussion_r847009287
##########
flink/v1.13/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUpsert.java:
##########
@@ -164,38 +169,31 @@ public void testUpsertAndQuery() {
public void testPrimaryKeyEqualToPartitionKey() {
// This is an SQL based reproduction of
TestFlinkIcebergSinkV2#testUpsertOnDataKey
Review Comment:
Can you remove this comment as well while you're updating this? It's no
longer applicable really and not hepful.
Thank you!
##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUpsert.java:
##########
@@ -130,15 +135,15 @@ public void testUpsertAndQuery() {
try {
sql("INSERT INTO %s VALUES " +
- "(1, 'a', TO_DATE('2022-03-01'))," +
- "(2, 'b', TO_DATE('2022-03-01'))," +
- "(1, 'b', TO_DATE('2022-03-01'))",
+ "(1, 'a', DATE '2022-03-01')," +
+ "(2, 'b', DATE '2022-03-01')," +
+ "(1, 'b', DATE '2022-03-01')",
tableName);
sql("INSERT INTO %s VALUES " +
- "(4, 'a', TO_DATE('2022-03-02'))," +
- "(5, 'b', TO_DATE('2022-03-02'))," +
- "(1, 'b', TO_DATE('2022-03-02'))",
+ "(4, 'a', DATE '2022-03-02')," +
+ "(5, 'b', DATE '2022-03-02')," +
+ "(1, 'b', DATE '2022-03-02')",
Review Comment:
Can we addd a comment about the usage of `DATE` vs `TO_DATE`, given that
we're relying on `DATE` to affect the generated job graph differently than
`TO_DATE?
A short comment and then directing to this comment might be sufficent:
https://github.com/apache/iceberg/issues/4515#issuecomment-1094462606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
