openinx commented on PR #4519: URL: https://github.com/apache/iceberg/pull/4519#issuecomment-1094761649
> Since we can't fix it in Flink 1.12, I think the right option is to disable it and ask the user to upgrade. Sorry, maybe I missed something. Is there any blocker that we cannot just fix this bug in flink 1.12 ? In my context, I think the approach to fix the bug in fink 1.12 is just porting the patch from flink1.13/1.14 to flink1.12, I usually just export it to a patch file and replace the `v1.14` to `v1.12` globally. I can also understand that we are planing to remove the flink 1.12 in the next iceberg release 0.14.0. But in iceberg release 0.13.2, I don't think we should remove flink 1.12 support because it's a bugfix release. So for the release 0.13.2, the correct approach is fixing this bug or disabling the `UPSERT` write feature. For me, fixing this bug in flink 1.12 seems more reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
