szehon-ho commented on code in PR #4516:
URL: https://github.com/apache/iceberg/pull/4516#discussion_r847670342
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -45,9 +45,10 @@
super(ops, table, name);
this.schema = new Schema(
- Types.NestedField.required(1, "partition",
table.spec().partitionType()),
- Types.NestedField.required(2, "record_count", Types.LongType.get()),
- Types.NestedField.required(3, "file_count", Types.IntegerType.get())
+ Types.NestedField.required(1, "spec_id", Types.IntegerType.get()),
Review Comment:
Hm I thought it means, we just need to keep the id of the other fields, but
could append in any position? ex,
```
Types.NestedField.required(4, "spec_id", Types.IntegerType.get()),
Types.NestedField.required(1, "partition", table.spec().partitionType()),
Types.NestedField.required(2, "record_count", Types.LongType.get()),
Types.NestedField.required(3, "file_count", Types.IntegerType.get())
```
Though I think its not a big deal, and we can put it in the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
