rdblue commented on code in PR #4495:
URL: https://github.com/apache/iceberg/pull/4495#discussion_r847750917
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -281,9 +281,9 @@ public void head(String path, Consumer<ErrorResponse>
errorHandler) {
@Override
public void close() throws IOException {
- if (catalog instanceof Closeable) {
- ((Closeable) catalog).close();
- }
+ // The calling test is responsible for closing the underlying catalog
backing this REST catalog
+ // so that the underlying backend catalog is not closed and reopened
during the REST catalog's
+ // initialize method when fetching the server configuration.
Review Comment:
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
