RussellSpitzer commented on code in PR #4377:
URL: https://github.com/apache/iceberg/pull/4377#discussion_r848692686
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -1038,6 +1046,128 @@ public void testInvalidAPIUsage() {
"Cannot set strategy", () ->
actions().rewriteDataFiles(table).sort(SortOrder.unsorted()).binPack());
}
+ @Test
+ public void testRewriteJobOrderBytesAsc() {
+ Table table = createTablePartitioned(4, 2);
Review Comment:
Sounds good to me, Just to make sure I would just have an assert in the test
that sorting in both directions is different :) That way any future changes to
parquet protocols would be automatically checked.
Ie Asstert expected == actual && expected.reversed != actual
Thanks for the change though, I just get paranoid about tests passing for
the wrong reasons sometimes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
