findepi commented on PR #4537: URL: https://github.com/apache/iceberg/pull/4537#issuecomment-1098007657
@rdblue i applied most of the comments (no more `jackson-datatype-jdk8`, json-related annotations, `get` in accessor names). I also switched over from base16-encoded test "fixtures" to test resources. I switched writing to use `ByteBuffer`, this removes removed data copying upon compression. This is as a fixup for now. Please let me know if you want me to use `ByteBuffer` in the reader/writer APIs as well? It seems `byte[]` works there well (eg because uncompressed size is known, so no need to re-allocation), so please confirm before I apply further changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
