hililiwei commented on code in PR #3991:
URL: https://github.com/apache/iceberg/pull/3991#discussion_r849494849
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/data/RowDataProjection.java:
##########
@@ -134,11 +176,26 @@ private static RowData.FieldGetter
createFieldGetter(RowType rowType,
public RowData wrap(RowData row) {
this.rowData = row;
+ this.valueCache.clear();
return this;
}
private Object getValue(int pos) {
- return getters[pos].getFieldOrNull(rowData);
+ return valueCache.computeIfAbsent(pos, key -> {
+ Object value = null;
+ if (projectedFields != null) {
+ int[] projectedField = projectedFields[key];
+ for (int index : projectedField) {
Review Comment:
Drill down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
