ggershinsky commented on code in PR #3470: URL: https://github.com/apache/iceberg/pull/3470#discussion_r850240108
########## core/src/test/java/org/apache/iceberg/encryption/kms/KeyStoreKmsClient.java: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.encryption.kms; + +import java.io.FileInputStream; +import java.io.FileNotFoundException; +import java.io.IOException; +import java.nio.ByteBuffer; +import java.security.KeyStore; +import java.security.KeyStoreException; +import java.security.NoSuchAlgorithmException; +import java.security.UnrecoverableKeyException; +import java.security.cert.CertificateException; +import java.util.Enumeration; +import java.util.Map; +import javax.crypto.SecretKey; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; + +/** + * KMS client demo class, based on the Java KeyStore API that reads keys from standard PKCS12 keystore files. + * Not for use in production. + */ +public class KeyStoreKmsClient extends MemoryMockKMS { + + // Path to keystore file. Preferably kept in volatile storage, such as ramdisk. Don't store with data. + public static final String KEYSTORE_FILE_PATH_PROP = "keystore.kms.client.file.path"; + + // Credentials (such as keystore password) must never be kept in a persistent storage. + // In this class, the password is passed as a system environment variable. + public static final String KEYSTORE_PASSWORD_ENV_VAR = "KEYSTORE_PASSWORD"; + + @Override + public String wrapKey(ByteBuffer key, String wrappingKeyId) { + // keytool keeps key names in lower case + return super.wrapKey(key, wrappingKeyId.toLowerCase()); + } + + @Override + public ByteBuffer unwrapKey(String wrappedKey, String wrappingKeyId) { + // keytool keeps key names in lower case + return super.unwrapKey(wrappedKey, wrappingKeyId.toLowerCase()); + } + + @Override + public void initialize(Map<String, String> properties) { + String keystorePath = properties.get(KEYSTORE_FILE_PATH_PROP); + Preconditions.checkNotNull(keystorePath, KEYSTORE_FILE_PATH_PROP + " must be set in hadoop or table " + + "properties"); + + String keystorePassword = System.getenv(KEYSTORE_PASSWORD_ENV_VAR); Review Comment: hey @RussellSpitzer , thanks for merging this . To answer the question - this is not a concern in a basic threat model, where we don't trust the storage domain, but we do trust the domain of compute nodes - we have to, because the node memory sees the sensitive data, the encryption keys, etc. The meaning of "trust" is a deep hole.., but to give a simple example, the compute nodes run in-house, while the storage backend is on another company's platform. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
