rdblue commented on code in PR #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r851368042
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java:
##########
@@ -339,15 +348,29 @@ public Builder setSnapshotProperty(String property,
String value) {
*/
@Deprecated
public DataStreamSink<RowData> build() {
- return chainIcebergOperators();
+ return append();
}
/**
* Append the iceberg sink operators to write records to iceberg table.
*
* @return {@link DataStreamSink} for sink.
*/
- public DataStreamSink<Void> append() {
+ @SuppressWarnings("rawtypes")
Review Comment:
It's okay to suppress unchecked, I didn't mean to imply in that comment that
the use of raw types is okay. This should cast, not remove type parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
