CircArgs commented on code in PR #4466:
URL: https://github.com/apache/iceberg/pull/4466#discussion_r851465498
##########
python/src/iceberg/expressions/base.py:
##########
@@ -122,3 +125,139 @@ def __le__(self, other):
def __ge__(self, other):
return self.value >= other.value
+
+
+class BooleanExpression(ABC):
+ """base class for all boolean expressions"""
+
+ @abstractmethod
+ def __invert__(self) -> "BooleanExpression":
+ ...
+
+
+class And(BooleanExpression):
+ """AND operation expression - logical conjunction"""
+
+ def __new__(cls, left: BooleanExpression, right: BooleanExpression, *rest:
BooleanExpression):
+ if rest:
+ return reduce(And, (left, right, *rest))
+ if left is AlwaysFalse() or right is AlwaysFalse():
+ return AlwaysFalse()
+ elif left is AlwaysTrue():
+ return right
+ elif right is AlwaysTrue():
+ return left
+ return super().__new__(cls)
+
+ def __init__(
+ self,
+ left: BooleanExpression,
+ right: BooleanExpression,
+ *rest: BooleanExpression,
+ ):
+ if not rest:
+ self.left = left
+ self.right = right
Review Comment:
Hey @rdblue, I was trying to suggest that it's not plainly ignored and that
`__new__` takes care of making sure `__init__` *is* only called with with
`left` and `right`. [This
test](https://github.com/apache/iceberg/blob/0e637d74ee3899db8d0a6363c5abf31547377e0f/python/tests/expressions/test_expressions_base.py#L159)
shows how `And` handles more arguments. Is that what you were thinking would
not work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
