CircArgs commented on code in PR #4466:
URL: https://github.com/apache/iceberg/pull/4466#discussion_r851546286
##########
python/src/iceberg/expressions/base.py:
##########
@@ -122,3 +125,139 @@ def __le__(self, other):
def __ge__(self, other):
return self.value >= other.value
+
+
+class BooleanExpression(ABC):
+ """base class for all boolean expressions"""
+
+ @abstractmethod
+ def __invert__(self) -> "BooleanExpression":
+ ...
+
+
+class And(BooleanExpression):
+ """AND operation expression - logical conjunction"""
+
+ def __new__(cls, left: BooleanExpression, right: BooleanExpression, *rest:
BooleanExpression):
+ if rest:
+ return reduce(And, (left, right, *rest))
+ if left is AlwaysFalse() or right is AlwaysFalse():
+ return AlwaysFalse()
+ elif left is AlwaysTrue():
+ return right
+ elif right is AlwaysTrue():
+ return left
+ return super().__new__(cls)
+
+ def __init__(
+ self,
+ left: BooleanExpression,
+ right: BooleanExpression,
+ *rest: BooleanExpression,
+ ):
+ if not rest:
+ self.left = left
+ self.right = right
Review Comment:
> `__init__` still exists and can be called directly. I don't think it
should assume it is always called through `__new__`.
Would you mind elaborating on what you mean by this? To my knowledge, there
is no calling init directly without implicitly calling new since new gives you
the base object and init essentially adds/modifies the attributes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
