szehon-ho commented on code in PR #4005:
URL: https://github.com/apache/iceberg/pull/4005#discussion_r851564828
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -48,7 +48,10 @@
this.schema = new Schema(
Types.NestedField.required(1, "partition",
table.spec().partitionType()),
Types.NestedField.required(2, "record_count", Types.LongType.get()),
- Types.NestedField.required(3, "file_count", Types.IntegerType.get())
+ Types.NestedField.required(3, "file_count", Types.IntegerType.get()),
+ Types.NestedField.required(4, "delete_file_count",
Types.IntegerType.get()),
+ Types.NestedField.required(5, "equality_delete_count",
Types.LongType.get()),
Review Comment:
Not sure if Ryan had any comment, so I still think we should rename it to
"positional/equality_delete_record_count". I dont see any point necessarily in
staying with snapshot-summary if that one is less clear.
##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java:
##########
@@ -516,6 +522,101 @@ public void testPartitionColumnNamedPartition() throws
Exception {
validateIncludesPartitionScan(tasksAndEq, 0);
}
+ @Test
+ public void testPartitionsTableScanWithDeleteFilesInFilter() throws
IOException {
+ Assume.assumeTrue(formatVersion == 2);
+ Configuration conf = new Configuration();
+ HadoopTables tables = new HadoopTables(conf);
Review Comment:
It actually works for me, I put it in the main comment.
##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java:
##########
@@ -516,6 +522,101 @@ public void testPartitionColumnNamedPartition() throws
Exception {
validateIncludesPartitionScan(tasksAndEq, 0);
}
+ @Test
+ public void testPartitionsTableScanWithDeleteFilesInFilter() throws
IOException {
+ Assume.assumeTrue(formatVersion == 2);
+ Configuration conf = new Configuration();
+ HadoopTables tables = new HadoopTables(conf);
+ File tableLocation = new File(temp.newFolder(), "table");
+ Table table = tables.create(
Review Comment:
I meant, the variable "table" is already instantiated correctly in the class
Before method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
