stevenzwu commented on code in PR #4580:
URL: https://github.com/apache/iceberg/pull/4580#discussion_r853406060
##########
api/src/main/java/org/apache/iceberg/TableScan.java:
##########
@@ -148,7 +89,9 @@ default TableScan select(String... columns) {
* @return a table scan which can read append data from {@code
fromSnapshotId}
* exclusive and up to {@code toSnapshotId} inclusive
*/
- TableScan appendsBetween(long fromSnapshotId, long toSnapshotId);
+ default TableScan appendsBetween(long fromSnapshotId, long toSnapshotId) {
+ throw new UnsupportedOperationException("Incremental scan is not
supported");
Review Comment:
this change is not strictly required for this change. I am ok to revert it.
I added it here as I was thinking about removing the duplicate code of
`UnsupportedOperationException` in many `TableScan` impl classes.
We can mark those two `appends` methods as deprecated once the new
IncrementalScan impls are ready. Yes, we can follow the compatibility rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
