samredai commented on code in PR #4590: URL: https://github.com/apache/iceberg/pull/4590#discussion_r853612744
########## python/src/iceberg/partitioning.py: ########## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from iceberg.transforms import Transform + + +class PartitionField: + """ + PartitionField is a single element with name and unique id, + It represents how one partition value is derived from the source column via transformation + """ Review Comment: ```suggestion Attributes: source_id(int): The field id of the source field in the spec's table schema field_id(int): The partition field id across all the table metadata's partition specs transform(Transform): The transform used to produce partition values from source values name(str): The name of this partition field """ ``` ########## python/src/iceberg/partitioning.py: ########## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from iceberg.transforms import Transform + + +class PartitionField: Review Comment: @rdblue do we need to define a hash method for this class? Maybe something like: ```py def __hash__(self): return hash((self.source_id, self.field_id, self.name, self.transform)) ``` ########## python/src/iceberg/partitioning.py: ########## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from iceberg.transforms import Transform + + +class PartitionField: + """ + PartitionField is a single element with name and unique id, + It represents how one partition value is derived from the source column via transformation + """ + + def __init__(self, source_id: int, field_id: int, transform: Transform, name: str): + self._source_id = source_id + self._field_id = field_id + self._transform = transform + self._name = name + + @property + def source_id(self) -> int: + return self._source_id + + @property + def field_id(self) -> int: + return self._field_id + + @property + def name(self) -> str: + return self._name + + @property + def transform(self) -> Transform: + return self._transform + + def __eq__(self, other): + return self.field_id == other.field_id + + def __str__(self): + return f"{self.field_id}: {self.name}: {self.transform}: ({self.source_id})" + + def __repr__(self): + return ( + f"PartitionField(field_id={self.field_id}, name={self.name}, transform={self._transform}, source_id={self.source_id})" Review Comment: nit: to be consistent with the other variables in the repr, `self._transform` should be `self.transform` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
