rajarshisarkar commented on PR #4586: URL: https://github.com/apache/iceberg/pull/4586#issuecomment-1105152105
Thanks for the inputs, @amogh-jahagirdar! I am carrying forward the call procedure approach from the [existing snapshot management APIs](https://iceberg.apache.org/docs/latest/spark-procedures/#snapshot-management): `rollback_to_snapshot`, `rollback_to_timestamp`, `set_current_snapshot`, `cherrypick_snapshot`. However, the SQL approach looks really interesting to me. Here are my thoughts: (1) Introduce call procedures for all the branching & tagging APIs as effectively they are snapshot management APIs and we already have [some existing procedural calls for the same](https://iceberg.apache.org/docs/latest/spark-procedures/#snapshot-management). The procedural calls could be API specific or generic enough to cater different use cases via named/positional arguments. (2) Introduce new SQL Syntax specific to branching and tagging - make changes in `IcebergSparkSessionExtensions` (and also in parser, analyzer, planner to understand the new syntax). The Syntax could be something similar to what Amogh suggested and can be proposed/reviewed in the community. I don't have a strong opinion on (1) or (2) - would like to just use Spark to create/modify/remove a branch/tag. I would also like to list/view details of the available branches/tags using Spark. @rdblue @jackye1995 Please let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
