kbendick commented on code in PR #4606:
URL: https://github.com/apache/iceberg/pull/4606#discussion_r855648057
##########
docs/spark/spark-ddl.md:
##########
@@ -98,6 +98,13 @@ CREATE TABLE prod.db.sample
USING iceberg
AS SELECT ...
```
+```sql
+CREATE TABLE prod.db.sample
+USING iceberg
+PARTITIONED BY (part)
+TBLPROPERTIES ('key'='value')
+AS SELECT ...
Review Comment:
I think it would make more sense to either:
1) Update the existing CTAS statement above to use partitioning plus
tblproperties.
2) Add a comment in between the two blocks indicating what's different
between the two.
I would prefer (1) given that the CTAS syntax is not iceberg specific, this
is just covering more Spark DML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
