flyrain commented on code in PR #4539:
URL: https://github.com/apache/iceberg/pull/4539#discussion_r855650667
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkFilesScan.java:
##########
@@ -50,6 +52,16 @@ class SparkFilesScan extends SparkScan {
this.splitOpenFileCost = readConf.splitOpenFileCost();
}
+ SparkFilesScan(SparkSession spark, Table table, SparkReadConf readConf,
Schema expectedSchema,
+ List<Expression> filterExpressions) {
+ super(spark, table, readConf, expectedSchema == null ? table.schema() :
expectedSchema, ImmutableList.of());
+
+ this.taskSetID = readConf.fileScanTaskSetId();
+ this.splitSize = readConf.splitSize();
+ this.splitLookback = readConf.splitLookback();
+ this.splitOpenFileCost = readConf.splitOpenFileCost();
Review Comment:
I can remove the first constructor since it is not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
