jackye1995 commented on code in PR #4423:
URL: https://github.com/apache/iceberg/pull/4423#discussion_r856525400
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -264,15 +266,24 @@ private boolean isGlueIcebergTable(Table table) {
@Override
public boolean dropTable(TableIdentifier identifier, boolean purge) {
+ TableOperations ops = newTableOps(identifier);
+ TableMetadata lastMetadata;
+ try {
+ lastMetadata = ops.current();
+ } catch (NoSuchKeyException ex) {
+ // S3 files already deleted, can not get S3 object through metadata
location
+ lastMetadata = null;
+ }
try {
- TableOperations ops = newTableOps(identifier);
- TableMetadata lastMetadata = ops.current();
glue.deleteTable(DeleteTableRequest.builder()
.catalogId(awsProperties.glueCatalogId())
.databaseName(IcebergToGlueConverter.getDatabaseName(identifier))
.name(identifier.name())
.build());
LOG.info("Successfully dropped table {} from Glue", identifier);
+ ValidationException.check(!purge ||
!awsProperties.glueLakeFormationEnabled() || lastMetadata == null,
Review Comment:
why do we need `lastMetadata = null` check in this validation? Seems
unnecessary to me
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -264,15 +266,24 @@ private boolean isGlueIcebergTable(Table table) {
@Override
public boolean dropTable(TableIdentifier identifier, boolean purge) {
+ TableOperations ops = newTableOps(identifier);
+ TableMetadata lastMetadata;
+ try {
+ lastMetadata = ops.current();
+ } catch (NoSuchKeyException ex) {
+ // S3 files already deleted, can not get S3 object through metadata
location
+ lastMetadata = null;
+ }
try {
- TableOperations ops = newTableOps(identifier);
- TableMetadata lastMetadata = ops.current();
glue.deleteTable(DeleteTableRequest.builder()
.catalogId(awsProperties.glueCatalogId())
.databaseName(IcebergToGlueConverter.getDatabaseName(identifier))
.name(identifier.name())
.build());
LOG.info("Successfully dropped table {} from Glue", identifier);
+ ValidationException.check(!purge ||
!awsProperties.glueLakeFormationEnabled() || lastMetadata == null,
Review Comment:
why do we need `lastMetadata = null` check in this validation? Seems
unnecessary to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
