flyrain commented on code in PR #4546:
URL: https://github.com/apache/iceberg/pull/4546#discussion_r856560326
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -433,6 +437,20 @@ void setSnapshotSummary(Map<String, String> parameters,
Snapshot currentSnapshot
}
}
+ private void setPartitionSpec(TableMetadata metadata, Map<String, String>
parameters) {
+ parameters.remove(TableProperties.DEFAULT_PARTITION_SPEC);
+ if (metadata.spec() != null && metadata.spec().isPartitioned()) {
+ parameters.put(TableProperties.DEFAULT_PARTITION_SPEC,
PartitionSpecParser.toJson(metadata.spec()));
Review Comment:
Added a new property `current-schema` to avoid adding column name into
partition spec and sort order. It duplicates the schema with Hive format, but
we think it's worth to do that. The Hive format loses important column info(id).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
