szehon-ho opened a new issue, #4618: URL: https://github.com/apache/iceberg/issues/4618
Reference: https://github.com/apache/iceberg/pull/4558, Preconditions.checkArgument only works with %s, as %d does not parse and returns a bad error message. We can make a checkstyle rule to prevent this, example of a checkstyle rule: https://github.com/apache/iceberg/blob/master/.baseline/checkstyle/checkstyle.xml#L54-L57 It should probably use multi-line regex rule as some of these are across multiple lines: https://checkstyle.sourceforge.io/config_regexp.html#RegexpMultiline (thanks @RussellSpitzer for pointer) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
