rdblue commented on code in PR #4622:
URL: https://github.com/apache/iceberg/pull/4622#discussion_r857184151
##########
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java:
##########
@@ -139,11 +142,11 @@ protected Catalog createCatalog(String name, Map<String,
String> properties, Con
return new FlinkCatalog(name, defaultDatabase, baseNamespace,
catalogLoader, cacheEnabled);
}
- private static Configuration mergeHiveConf(Configuration hadoopConf, String
hiveConfDir) {
+ private static Configuration mergeHiveConf(Configuration hadoopConf, String
hiveConfDir, String hadoopConfDir) {
Configuration newConf = new Configuration(hadoopConf);
if (!Strings.isNullOrEmpty(hiveConfDir)) {
Preconditions.checkState(Files.exists(Paths.get(hiveConfDir,
"hive-site.xml")),
- "There should be a hive-site.xml file under the directory %s",
hiveConfDir);
+ "There should be a hive-site.xml file under the directory %s",
hiveConfDir);
Review Comment:
Please revert unnecessary changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
