jackye1995 commented on code in PR #4443: URL: https://github.com/apache/iceberg/pull/4443#discussion_r858174325
########## docs/integrations/aws.md: ########## @@ -419,9 +419,23 @@ If for any reason you have to use S3A, here are the instructions: To ensure integrity of uploaded objects, checksum validations for S3 writes can be turned on by setting catalog property `s3.checksum-enabled` to `true`. This is turned off by default. +### S3 Delete + +When the catalog property `s3.delete-enabled` is set to `false`, the objects are not deleted from S3. +This is set to `true` by default. Review Comment: we should link to the next section with something in the line of "This is expected to be used in combination with s3 delete tagging", so objects are tagged and removed using S3 lifecycle policy. See xxx (link to next section) for more details". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
