Andre9580 commented on code in PR #4630:
URL: https://github.com/apache/iceberg/pull/4630#discussion_r858251545
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -295,7 +295,7 @@ public void deleteWhere(Filter[] filters) {
.deleteFromRowFilter(deleteExpr)
.commit();
} catch (ValidationException e) {
- throw new IllegalArgumentException("Failed to cleanly delete data files
matching: " + deleteExpr, e);
+ throw new ValidationException(e, "Failed to cleanly delete data files
matching: %s", deleteExpr);
Review Comment:
Updated the code, however regarding "we can even remove it from method's
throw clause" I am not sure to follow you, if you can explain this it would be
great since I thought we actually wanted to throw a `ValidationException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
