pvary commented on PR #4546: URL: https://github.com/apache/iceberg/pull/4546#issuecomment-1110226565
@flyrain: Yes, it uses the [HiveIcebergStorageHandler.getPartitionTransformSpec](https://github.com/apache/hive/blob/dbdcf00dd6334acaded4369fc0c1ccbdd142255e/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java#L330) which in turn uses [IcebergTableUtil.getTable](https://github.com/apache/hive/blob/dbdcf00dd6334acaded4369fc0c1ccbdd142255e/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java#L54) to load the table and read the spec from the table snapshot. When we were working on creating Hive tables, I have started working on the Hive table creation we used the `spec` and the `schema` table property fields, but then we decided on removing them and keep the metadata json as a single source of truth. See: [HiveIcebergMetaHook. PROPERTIES_TO_REMOVE](https://github.com/apache/iceberg/blob/master/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java#L62). I hope this does not cause issues with the new code when the table is created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
