szehon-ho commented on code in PR #4629:
URL: https://github.com/apache/iceberg/pull/4629#discussion_r859178563
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##########
@@ -176,16 +184,55 @@ protected Dataset<Row> loadMetadataTable(Table table,
MetadataTableType type) {
return SparkTableUtil.loadMetadataTable(spark, table, type);
}
- private static class ReadManifest implements
FlatMapFunction<ManifestFileBean, String> {
- private final Broadcast<FileIO> io;
+ private static class ReadManifest implements
FlatMapFunction<ManifestFileBean, ContentFileTypeBean> {
+ private final Broadcast<Table> table;
- ReadManifest(Broadcast<FileIO> io) {
- this.io = io;
+ ReadManifest(Broadcast<Table> table) {
+ this.table = table;
}
@Override
- public Iterator<String> call(ManifestFileBean manifest) {
- return new ClosingIterator<>(ManifestFiles.readPaths(manifest,
io.getValue()).iterator());
+ public Iterator<ContentFileTypeBean> call(ManifestFileBean manifest) {
+ switch (manifest.content()) {
+ case DATA:
+ return CloseableIterator.transform(
+ ManifestFiles.read(manifest, table.getValue().io(),
table.getValue().specs()).iterator(),
+ ContentFileTypeBean::toContentFilePathBean);
Review Comment:
Hm a little confused how this will work, In the end, won't the
iterator.next() always return the same instance with same file/type which is
incorrect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
