kbendick commented on issue #4624: URL: https://github.com/apache/iceberg/issues/4624#issuecomment-1110554296
Note that we should strongly consider whether or not to backport this to Flink 1.14. If the fix was applied in Flink 1.14.5, and users use Flink 1.14.2 at runtime, they’ll likely encounter an issue. If this is super performance critical, we can consider adding a flag or something to opt-in for Flink 1.14, but it seems the patch fix has somewhat broken API comparability for Flink 1.14.x. shameless plug for my PR that would add binary / semantic / API compatibility checks, at least to the API module: https://github.com/apache/iceberg/pull/4638 also, if you’re ever curious, you can apply that plug-in to `allsubprojects` to see if that catches the issue after changing it. I suspect it would (though generally speaking we only intend on defining binary / source / semantic compatibility guarantees for the api module). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
