RussellSpitzer commented on code in PR #4637:
URL: https://github.com/apache/iceberg/pull/4637#discussion_r861341626
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -149,14 +150,15 @@ static CloseableIterable<FileScanTask>
planFiles(StaticTableScan scan) {
Snapshot snapshot = table.snapshot(scan.snapshot().snapshotId());
boolean caseSensitive = scan.isCaseSensitive();
- // use an inclusive projection to remove the partition name prefix and
filter out any non-partition expressions
- Expression partitionFilter = Projections
- .inclusive(transformSpec(scan.schema(), table.spec()), caseSensitive)
- .project(scan.filter());
+ LoadingCache<Integer, ManifestEvaluator> evalCache =
Caffeine.newBuilder().build(specId -> {
Review Comment:
Not sure we need the full LoadingCache here, but I'm ok with it if you like,
we could probably just proactively build the full set of evaluators for all
specs in the metadata. I probably should have suggested this before on the
other PR as well. Since we know we will need every single evaluator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
