kbendick commented on code in PR #4668:
URL: https://github.com/apache/iceberg/pull/4668#discussion_r861455359
##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -116,19 +119,23 @@ public static void toJson(MetadataUpdate metadataUpdate,
JsonGenerator generator
case ASSIGN_UUID:
throw new UnsupportedOperationException("Not Implemented:
MetadataUpdate#toJson for AssignUUID");
case UPGRADE_FORMAT_VERSION:
- writeAsUpgradeFormatVersion((MetadataUpdate.UpgradeFormatVersion)
metadataUpdate, generator);
+ writeUpgradeFormatVersion((MetadataUpdate.UpgradeFormatVersion)
metadataUpdate, generator);
break;
case ADD_SCHEMA:
- writeAsAddSchema((MetadataUpdate.AddSchema) metadataUpdate, generator);
+ writeAddSchema((MetadataUpdate.AddSchema) metadataUpdate, generator);
break;
case SET_CURRENT_SCHEMA:
- writeAsSetCurrentSchema((MetadataUpdate.SetCurrentSchema)
metadataUpdate, generator);
+ writeSetCurrentSchema((MetadataUpdate.SetCurrentSchema)
metadataUpdate, generator);
+ break;
+ case ADD_PARTITION_SPEC:
+ writeAddPartitionSpec((MetadataUpdate.AddPartitionSpec)
metadataUpdate, generator);
break;
case SET_DEFAULT_PARTITION_SPEC:
-
writeAsSetDefaultPartitionSpec((MetadataUpdate.SetDefaultPartitionSpec)
metadataUpdate, generator);
+ writeSetDefaultPartitionSpec((MetadataUpdate.SetDefaultPartitionSpec)
metadataUpdate, generator);
break;
- case ADD_PARTITION_SPEC:
Review Comment:
This is where `ADD_PARTITION_SPEC` was moved up to match the declaration
order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
