kbendick commented on code in PR #4638: URL: https://github.com/apache/iceberg/pull/4638#discussion_r861428232
########## dev/.rat-excludes: ########## @@ -9,6 +9,7 @@ build .rat-excludes LICENSE NOTICE +revapi.yml Review Comment: Unfortunately, it will have to go in the `.rat-excludes` file. I added the header, then ran `./gradlew iceberg-api:revapiAcceptAllBreaks --justification "Testing YAML comment on top of file"` to cause an update to the file. The resulting file output had the header removed (essentially a full rewrite of the file). So unless we want to manually re-enter the license header every time we make a chance to the file, it needs to be excluded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
