rdblue commented on issue #4666: URL: https://github.com/apache/iceberg/issues/4666#issuecomment-1113712458
@dilipbiswal, can you share the OOM stack trace that caused this? That stack trace will allow us to see where the exception is propagating. There is a slight risk if anything fails after actually committing to the catalog, which we avoid by not doing any work in commit other than returning. That's why `BaseMetastoreCatalog` sets a flag to refresh the table, but the refresh actually happens in the cleanup after the commit. And, if there's any problem in the cleanup then it just warns and stops (which is why @RussellSpitzer's test works). It could be that the OOM happened after the commit succeeded, or at least after the commit was sent to the server and eventually succeeded. But the problem is that OOM should not have triggered the `cleanAll` behavior. It should have prevented all cleanup: `cleanAll` happens when a `RuntimeException` is caught in the commit block, and any further exceptions block cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
