rdblue commented on code in PR #4518:
URL: https://github.com/apache/iceberg/pull/4518#discussion_r862260352
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -272,6 +273,13 @@ public static FileIO loadFileIO(
configureHadoopConf(fileIO, hadoopConf);
fileIO.initialize(properties);
+
+ // Check if we should wrap this with CachingFileIO
Review Comment:
Minor: personal pronouns like "I" and "we" usually make comments longer and
harder to read. More direct statements like `Check whether to wrap with
CachingFileIO` are preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
