ajantha-bhat commented on code in PR #4674:
URL: https://github.com/apache/iceberg/pull/4674#discussion_r862493820
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteReachableFilesSparkAction.java:
##########
@@ -125,8 +126,9 @@ private Result doExecute() {
private Dataset<Row> buildReachableFileDF(TableMetadata metadata) {
Table staticTable = newStaticTable(metadata, io);
- return withFileType(buildValidContentFileDF(staticTable), CONTENT_FILE)
- .union(withFileType(buildManifestFileDF(staticTable), MANIFEST))
+ Dataset<Row> allManifests = loadMetadataTable(staticTable, ALL_MANIFESTS);
+ return withFileType(buildValidContentFileDF(staticTable, allManifests),
CONTENT_FILE)
+ .union(withFileType(buildManifestFileDF(allManifests), MANIFEST))
Review Comment:
It seems, individual test cases passes. But when whole suit is ran,
persist() is causing failures for hadoop catalog. Not sure why. I might have to
explore more on this. Probably I need some job completion listener to
unpersist().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
