samredai commented on code in PR #4678: URL: https://github.com/apache/iceberg/pull/4678#discussion_r863060605
########## python/src/iceberg/schema.py: ########## @@ -19,7 +19,10 @@ import sys from abc import ABC, abstractmethod -from typing import Dict, Generic, Iterable, List, TypeVar +from typing import TYPE_CHECKING, Dict, Generic, Iterable, List, TypeVar + +if TYPE_CHECKING: + from iceberg.expressions.base import Accessor Review Comment: Sorry I forgot to mention that the circular import happens when PR #4679 is combined with this since that adds an import from schema in `expressions/base.py` so this is preemptive, specifically for [this](https://github.com/apache/iceberg/pull/4679/files#diff-47510d45242fa16200be79774cb6177b3084a1d363e15fde90940b3949a9eabaR23) line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
