rdblue commented on code in PR #4677:
URL: https://github.com/apache/iceberg/pull/4677#discussion_r863107149
##########
core/src/main/java/org/apache/iceberg/SnapshotSummary.java:
##########
@@ -236,6 +248,10 @@ void clear() {
void addTo(ImmutableMap.Builder<String, String> builder) {
setIf(addedFiles > 0, builder, ADDED_FILES_PROP, addedFiles);
setIf(removedFiles > 0, builder, DELETED_FILES_PROP, removedFiles);
+ setIf(addedEqDeleteFiles > 0, builder, ADD_EQ_DELETE_FILES_PROP,
addedEqDeleteFiles);
+ setIf(removedEqDeleteFiles > 0, builder, REMOVED_EQ_DELETE_FILES_PROP,
removedEqDeleteFiles);
+ setIf(addedPosDeleteFiles > 0, builder, ADD_POS_DELETE_FILES_PROP,
addedPosDeleteFiles);
+ setIf(removedPosDeleteFiles > 0, builder, REMOVED_POS_DELETE_FILES_PROP,
removedPosDeleteFiles);
setIf(addedDeleteFiles > 0, builder, ADDED_DELETE_FILES_PROP,
addedDeleteFiles);
setIf(removedDeleteFiles > 0, builder, REMOVED_DELETE_FILES_PROP,
removedDeleteFiles);
Review Comment:
Deprecating things is quite a bit of work for little gain here. I'd just
continue to update them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
