kbendick commented on code in PR #4670:
URL: https://github.com/apache/iceberg/pull/4670#discussion_r863539850
##########
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java:
##########
@@ -126,7 +133,9 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
objectPath.getObjectName());
}
- return new IcebergTableSink(tableLoader, tableSchema);
+ boolean upsert = PropertyUtil.propertyAsBoolean(tableProps,
WRITE_UPSERT_ENABLED.key(), false);
Review Comment:
Can we add a constant for the default value here, similar to
`TableProperties.UPSERT_ENABLED_DEFAULT`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
