rdblue commented on code in PR #4448:
URL: https://github.com/apache/iceberg/pull/4448#discussion_r863911381
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -516,6 +517,29 @@ public void testLoadMissingTable() {
() -> catalog.loadTable(ident));
}
+ @Test
+ public void testRenameTable() {
+ C catalog = catalog();
+
+ if (requiresNamespaceCreate()) {
+ catalog.createNamespace(NS);
+ }
+
+ Assert.assertFalse("Source table should not exist before create",
catalog.tableExists(TABLE));
+
+ catalog.buildTable(TABLE, SCHEMA).create();
+ Assert.assertTrue("Table should exist after create",
catalog.tableExists(TABLE));
+
+ Assert.assertFalse("Destination table should not exist before rename",
catalog.tableExists(RENAMED_TABLE));
+
+ catalog.renameTable(TABLE, RENAMED_TABLE);
+ Assert.assertTrue("Table should exist with new name",
catalog.tableExists(RENAMED_TABLE));
+ Assert.assertFalse("Original table should no longer exist",
catalog.tableExists(TABLE));
+
+ catalog.dropTable(RENAMED_TABLE);
+ assertEmpty("Should not contain table after drop", catalog, NS);
+ }
Review Comment:
I hit the same problem when testing create table atomicity and [fixed it
similarly](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java#L126-L129).
There's more background in [this
thread](https://github.com/apache/iceberg/pull/4319#pullrequestreview-909504774).
I'd probably use the same logic as in that fix, which checks the message for
"constraint failed".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
