flyrain commented on PR #4687: URL: https://github.com/apache/iceberg/pull/4687#issuecomment-1116766515
LGTM. Can we manager to add a test case? A little bit comment on the unknown exception. If the commit actually failed, which is more likely, the job failed, and we've got a bunch of orphan file. It is pretty tricky when the commit actually succeeded, it throws unknown exception, the job failed. What if users retry the job? Users may append the same data twice in case of retry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
