samredai commented on code in PR #4229:
URL: https://github.com/apache/iceberg/pull/4229#discussion_r864402646
##########
docs/versioned/spark/spark-procedures.md:
##########
@@ -280,6 +280,11 @@ See the [`RewriteDataFiles` Javadoc](../../../javadoc/{{%
icebergVersion %}}/org
and <br/> [`SortStrategy` Javadoc](../../../javadoc/{{% icebergVersion
%}}/org/apache/iceberg/actions/SortStrategy.html#field.summary)
for list of all the supported options for this action.
+!!! Note
+ This procedure can also read the delete files created by merge-on-read
mode if present
+ and rewrite to new data files by masking the result from delete files.
+ By default, delete files will not be considered for compaction. Need to
configure `delete-file-threshold` in options.
Review Comment:
For the last sentence, I think writing it out may read better, what do you
think of this?:
```diff
- Need to configure `delete-file-threshold` in options.
+ In order to change this behavior, you need to set `delete-file-threshold`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
