felixYyu commented on PR #4691:
URL: https://github.com/apache/iceberg/pull/4691#issuecomment-1117064387

   Static Analysis waring, I think it better ImmutableList.of() @Fokko ```
   
iceberg\core\src\main\java\org\apache\iceberg\io\MultiBufferInputStream.java:179:
 [MixedMutabilityReturnType] This method returns both mutable and immutable 
collections or maps from different paths. This may be confusing for users of 
the method.
     public List<ByteBuffer> sliceBuffers(long len) throws EOFException {
                             ^
       (see https://errorprone.info/bugpattern/MixedMutabilityReturnType)
     Did you mean 'return ImmutableList.of();'?
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to