kbendick commented on code in PR #4448: URL: https://github.com/apache/iceberg/pull/4448#discussion_r865119936
########## core/src/main/java/org/apache/iceberg/rest/requests/RenameTableRequest.java: ########## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.requests; + +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.rest.RESTRequest; + +/** + * A REST request to rename a table. + */ +public class RenameTableRequest implements RESTRequest { + + private TableIdentifier source; + private TableIdentifier destination; + + @SuppressWarnings("unused") + public RenameTableRequest() { + // Needed for Jackson Deserialization. + } + + private RenameTableRequest(TableIdentifier source, TableIdentifier destination) { + this.source = source; + this.destination = destination; + validate(); + } + + public void validate() { + Preconditions.checkArgument(source != null, "Invalid source table: null"); + Preconditions.checkArgument(destination != null, "Invalid destination table: null"); + Preconditions.checkArgument(!source.equals(destination), + "Invalid rename table request: source must not be the same as destination"); Review Comment: I suppose it can be a no-op given we've been somewhat permissive in terms of what is allowed to come through the requests (so that implementors can have discretion as to how they respond to these situations). I looked at the Glue catalog, and it doesn't specifically check for this case at all. Though I imagine their server fails at the end. In terms of making it a no-op, should we just let the client send the request and allow the server to deal with it? Maybe log a warning? Seems somewhat difficult to adjust the control flow from the validate function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
