rdblue commented on code in PR #4660:
URL: https://github.com/apache/iceberg/pull/4660#discussion_r865153211
##########
core/src/main/java/org/apache/iceberg/SnapshotSummary.java:
##########
@@ -181,14 +181,14 @@ public Map<String, String> build() {
builder.putAll(properties);
metrics.addTo(builder);
- setIf(deletedDuplicateFiles > 0, builder, DELETED_DUPLICATE_FILES,
deletedDuplicateFiles);
+ SnapshotSummary.set(builder, DELETED_DUPLICATE_FILES,
deletedDuplicateFiles);
Review Comment:
I think it probably makes more sense to just call `set` directly. There's no
need for a static method anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
