RussellSpitzer commented on code in PR #4610:
URL: https://github.com/apache/iceberg/pull/4610#discussion_r865199445
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -223,16 +223,16 @@ public boolean dropNamespace(Namespace namespace) throws
NamespaceNotEmptyExcept
@Override
public boolean setProperties(Namespace namespace, Map<String, String>
properties) {
- throw new UnsupportedOperationException(
- "Cannot set properties for namespace '" + namespace +
- "': setProperties is not supported by the NessieCatalog");
+ client.setProperties(namespace, properties);
Review Comment:
I would probably just have the client method return a boolean and then force
the true in there rather than at this level in the Catalog. But that's just my
opinion, up to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
