szehon-ho commented on PR #3457: URL: https://github.com/apache/iceberg/pull/3457#issuecomment-1118070274
I'm not sure if people think these changes are too hacky. Another option I've thought, is to implement IncrementalScan (https://github.com/apache/iceberg/pull/4580) for All_files table (to be added in https://github.com/apache/iceberg/pull/4694), which will allow snapshot filtering. Then rewrite ExpireSnapshotAction to use that table. I wonder was there was some reason initially to use all_manifests table and ManifestReadTask, rather than relying on all_files table? @rdblue @aokolnychyi for any thoughts/information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
