liuml07 opened a new pull request, #4699: URL: https://github.com/apache/iceberg/pull/4699
Initially I found the `TestIcebergFilesCommitter.java` always use the parquet file format for delete files. I think why not test with the parameterized file format as the data file does. Then I found the Flink sink tests maintain and pass variable `tablePath` unnecessarily. It can be replaced with `table` when comparing results, and can be replaced with `table.location()` when the absolute path is required. I think the fix is straightforward enough so I consolidate the changes in this PR: - Make sure the committer test use parameterized file format - Simply test variables by removing `tablePath` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
