kbendick commented on PR #4716: URL: https://github.com/apache/iceberg/pull/4716#issuecomment-1120585935
Given this is a much larger change set than I'd expected, and one or two of the classes need to be aligned with the spec, I'm going to use this PR as a template and open a series of PRs. I'll add tasks to that to make it easier to track but the general goal is: 1) Full shell of all needed functions, so individual changes are easy to make. 2) Add implementations and tests for the simplest classes 3) Add implementations and tests for any classes that are simple except for needing to update `JsonUtil` 4) Open a PR for classes that require a closer look, like `RemoveSnapshots` which allows for a set of snapshotIds to remove per the spec, but the implementation only accepts one value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
