SinghAsDev commented on code in PR #4692:
URL: https://github.com/apache/iceberg/pull/4692#discussion_r868588696
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -581,8 +581,13 @@ private static class WriterFactory implements
DataWriterFactory, StreamingDataWr
private final StructType dsSchema;
private final boolean partitionedFanoutEnabled;
- protected WriterFactory(Broadcast<Table> tableBroadcast, FileFormat
format, long targetFileSize,
- Schema writeSchema, StructType dsSchema, boolean
partitionedFanoutEnabled) {
+ protected WriterFactory(
Review Comment:
Thanks, dropped.
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java:
##########
@@ -128,7 +133,8 @@ public WriteBuilder overwrite(Filter[] filters) {
@Override
public Write build() {
// Validate
- Preconditions.checkArgument(handleTimestampWithoutZone ||
!SparkUtil.hasTimestampWithoutZone(table.schema()),
+ Preconditions.checkArgument(
Review Comment:
Thanks, dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
