zinking commented on code in PR #3681:
URL: https://github.com/apache/iceberg/pull/3681#discussion_r869810223
##########
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -377,6 +378,23 @@ void createIcebergTable(ObjectPath tablePath,
CatalogBaseTable table, boolean ig
PartitionSpec spec = toPartitionSpec(((CatalogTable)
table).getPartitionKeys(), icebergSchema);
ImmutableMap.Builder<String, String> properties = ImmutableMap.builder();
+
+ List<WatermarkSpec> watermarkSpecs = table.getSchema().getWatermarkSpecs();
+ if (watermarkSpecs != null) {
+ for (int i = 0; i < watermarkSpecs.size(); i++) {
Review Comment:
@hameizi if only one water mark is allowed why bother the for loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
